[webkit-reviews] review requested: [Bug 86051] [chromium] Scale all compositor output by deviceScaleFactor : [Attachment 142122] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 86051: [chromium] Scale all compositor output by deviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=86051

Attachment 142122: Patch
https://bugs.webkit.org/attachment.cgi?id=142122&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Alright, this is getting into a good state now. Testing with pinch/scroll on
device.

There's some issues with partial swap:
http://code.google.com/p/chromium/issues/detail?id=128268

- Scroll and pinch seem to be working well! Scaling things from physical pixels
to DIP when making scroll positions.
- Returning 1 as pageScaleFactor() on NCCH always, but calling
dOrPScaleFactorChanged() when it is changed in the WebView.
- Moving the code to set the deviceScaleFactor out of ChromeClientImpl and into
RenderViewImpl in chromium (separate CL). It will happen in the same place that
fixed-layout mode is enabled/disabled. This makes lots of sense since setting
of the deviceScaleFactor in this way is tied to not being in fixed-layout mode.