[webkit-reviews] review denied: [Bug 86556] [Worker] Web Worker lacks test for posting structured data message. : [Attachment 142121] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 15 18:45:14 PDT 2012
David Levin <levin at chromium.org> has denied Li Yin <li.yin at intel.com>'s request
for review:
Bug 86556: [Worker] Web Worker lacks test for posting structured data message.
https://bugs.webkit.org/show_bug.cgi?id=86556
Attachment 142121: Patch
https://bugs.webkit.org/attachment.cgi?id=142121&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142121&action=review
Seems ok. Just a few nits to fix up.
> LayoutTests/fast/workers/resources/worker-structure-message.js:7
> + var buf = new ArrayBuffer(20);
Why is this allocated here? I don't see it being used.
> LayoutTests/fast/workers/worker-structure-message.html:5
> +Should print "DONE" when done.</p>
On success, you should see...
More information about the webkit-reviews
mailing list