[webkit-reviews] review denied: [Bug 84613] Insert source file and line number for v8 function calls into tracing : [Attachment 138381] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Adrienne Walker
<enne at google.com>'s request for review:
Bug 84613: Insert source file and line number for v8 function calls into
tracing
https://bugs.webkit.org/show_bug.cgi?id=84613

Attachment 138381: Patch
https://bugs.webkit.org/attachment.cgi?id=138381&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138381&action=review


> Source/WebCore/ChangeLog:7
> +

Please explain the rational for the change.

> Source/WebCore/bindings/v8/V8Proxy.cpp:435
> +    Vector<UChar> combine;
> +    append(combine, resourceName);
> +    combine.append(':');
> +    appendNumber(combine, lineNumber);
> +
> +    String final;
> +    final = String::adopt(combine);
> +    return final;

Shall we use StringBuilder?

> Source/WebCore/platform/chromium/TraceEvent.h:677
> +    explicit TraceStringWithCopy(const unsigned char* str) :
m_str(reinterpret_cast<const char*>(str)) { }

What is this change for?