[webkit-reviews] review denied: [Bug 86522] Expose HTTP (major, minor) version in HTTP responses : [Attachment 142050] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 86522: Expose HTTP (major,minor) version in HTTP responses
https://bugs.webkit.org/show_bug.cgi?id=86522

Attachment 142050: Patch
https://bugs.webkit.org/attachment.cgi?id=142050&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142050&action=review


Seems reasonable to expose this information.

One can certainly parse HTTP version from information exposed by network
back-end. This patch doesn't do that however - it just adds a getter and a
setter(?!).

To add an httpVersionNumber() function to ResourceResponseBase, one needs to
make it work with all network back-ends - adding a cross-platform function that
just lies is not good. You can grep for how it's done for other data members,
such as m_httpStatusLine.

> Source/WebCore/platform/network/ResourceResponseBase.h:75
> +    void httpVersionNumber(int* major, int* minor) const;

Can we use references or even just a BCD-coded number?