[webkit-reviews] review granted: [Bug 86519] Block freeing thread should not free blocks when we are actively requesting them : [Attachment 142045] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 86519: Block freeing thread should not free blocks when we are actively
requesting them
https://bugs.webkit.org/show_bug.cgi?id=86519

Attachment 142045: Patch
https://bugs.webkit.org/attachment.cgi?id=142045&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142045&action=review


r=me

> Source/JavaScriptCore/heap/BlockAllocator.h:69
> +    m_isCurrentlyAllocating = true;
>      MutexLocker locker(m_freeBlockLock);

Let's put this assignment inside the lock, to guarantee proper synchronization.