[webkit-reviews] review denied: [Bug 85581] Percentage height replaced elements sometimes cause overflow of table contents : [Attachment 141489] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 15 13:49:49 PDT 2012
Eric Seidel <eric at webkit.org> has denied Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 85581: Percentage height replaced elements sometimes cause overflow of
table contents
https://bugs.webkit.org/show_bug.cgi?id=85581
Attachment 141489: Patch
https://bugs.webkit.org/attachment.cgi?id=141489&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm happy to reivew this. But why do we need the wall of text? And does this
need to be a pixel test? Can we use a dumpAsText or reference test instead?
Can we use a div/divs with fixed heights instead of the wall fo text?
inline-blocks will flow like text and you can control their size.
r- because the test could be much better. Otherwise the chagne looks OK.
More information about the webkit-reviews
mailing list