[webkit-reviews] review requested: [Bug 86409] Site-specific hack: Disclaim WebM as a supported type on Mac for YouTube. : [Attachment 142036] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 12:56:34 PDT 2012


Jer Noble <jer.noble at apple.com> has asked  for review:
Bug 86409: Site-specific hack: Disclaim WebM as a supported type on Mac for
YouTube.
https://bugs.webkit.org/show_bug.cgi?id=86409

Attachment 142036: Patch
https://bugs.webkit.org/attachment.cgi?id=142036&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
Moved the site-specific hack into MediaPlayer.	This required a new
MediaPlayerClient prototype, exposed both on HTMLMediaElement and from within
DOMImplementation.

Conceivably, I could push this further into MediaPlayerPrivateQTKit, but that
would require changing the MediaEngineSupportsType signature, which would in
turn require changing every MediaPlayerPrivate instance on every platform,
which would be very disruptive.


More information about the webkit-reviews mailing list