[webkit-reviews] review denied: [Bug 86504] [Chromium] Expose WebView to graphics context creation. : [Attachment 142014] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 12:39:39 PDT 2012


James Robinson <jamesr at chromium.org> has denied Sean Hunt
<scshunt at csclub.uwaterloo.ca>'s request for review:
Bug 86504: [Chromium] Expose WebView to graphics context creation.
https://bugs.webkit.org/show_bug.cgi?id=86504

Attachment 142014: Patch
https://bugs.webkit.org/attachment.cgi?id=142014&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142014&action=review


> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:161
> +    virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const
WebGraphicsContext3D::Attributes&, WebView*) { return 0; };

offscreen contexts are not associated with any WebView, so this is wrong.


More information about the webkit-reviews mailing list