[webkit-reviews] review granted: [Bug 86505] [WK2] Crash when dropping a reference to a non-existing file : [Attachment 142020] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 86505: [WK2] Crash when dropping a reference to a non-existing file
https://bugs.webkit.org/show_bug.cgi?id=86505

Attachment 142020: proposed fix
https://bugs.webkit.org/attachment.cgi?id=142020&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142020&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2191
> +	       RefPtr<SandboxExtension> extension =
SandboxExtension::create(sandboxExtensionsHandleArray[i]);
> +	       if (extension)
> +		   m_pendingDropExtensionsForFileUpload.append(extension);

I would have put the definition inside the if statement.