[webkit-reviews] review granted: [Bug 86501] add unit test for NRWT's --additional-expectations option : [Attachment 142007] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted epoger at google.com's request for
review:
Bug 86501: add unit test for NRWT's --additional-expectations option
https://bugs.webkit.org/show_bug.cgi?id=86501

Attachment 142007: Patch
https://bugs.webkit.org/attachment.cgi?id=142007&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142007&action=review


tests++

> Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:296
> +	       '/tmp/additional-expectations-1.txt']
> +	   self.assertEquals('content1\n', port.test_expectations_overrides())
> +
> +	   port._options.additional_expectations = [
> +	       '/tmp/nonexistent-file', '/tmp/additional-expectations-1.txt']

It surprises me that we don't raise an error when you pass in a non-existant
file. Is there a use-case for that? 

Obviously, this patch is fine since it's just testing the existing behavior.