[webkit-reviews] review denied: [Bug 86416] Use posZOrderList() / negZOrderList() everywhere to avoid querying dirtied lists : [Attachment 141823] Proposed change, fixed 2 places where the ASSERTs where triggering.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 86416: Use posZOrderList() / negZOrderList() everywhere to avoid querying
dirtied lists
https://bugs.webkit.org/show_bug.cgi?id=86416

Attachment 141823: Proposed change, fixed 2 places where the ASSERTs where
triggering.
https://bugs.webkit.org/attachment.cgi?id=141823&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141823&action=review


> Source/WebCore/rendering/RenderLayer.cpp:745
> +	   if (posZOrderList()) {
> +	       for (unsigned i = 0; i < posZOrderList()->size(); ++i)
> +		   m_has3DTransformedDescendant |=
posZOrderList()->at(i)->update3DTransformedDescendantStatus();

To avoid 3 calls through posZOrderList() it might be better to do if
(Vector<...> list = postZOrderList()) { ... }

> Source/WebCore/rendering/RenderLayer.cpp:751
> +	   if (negZOrderList()) {
> +	       for (unsigned i = 0; i < negZOrderList()->size(); ++i)
> +		   m_has3DTransformedDescendant |=
negZOrderList()->at(i)->update3DTransformedDescendantStatus();

Ditto.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1751
> +    return layer->negZOrderList() && layer->negZOrderList()->size() > 0;

Can we make this an accessor on RenderLayer, like hasNegZOrderChildren() or
something?