[webkit-reviews] review denied: [Bug 83012] Web Inspector: localStorage items are not updated when the storage changes : [Attachment 141923] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 15 08:35:29 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 83012: Web Inspector: localStorage items are not updated when the storage
changes
https://bugs.webkit.org/show_bug.cgi?id=83012
Attachment 141923: Patch
https://bugs.webkit.org/attachment.cgi?id=141923&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141923&action=review
> LayoutTests/inspector/storage-panel-dom-storage-update.html:66
> + if( storage.isLocalStorage ) {
Still wrong formatting here.
> LayoutTests/inspector/storage-panel-dom-storage-update.html:81
> + if( count < 6 )
ditto
> LayoutTests/inspector/storage-panel-dom-storage-update.html:102
> + InspectorTest.runAfterPendingDispatches( function() {
ditto
> LayoutTests/inspector/storage-panel-dom-storage-update.html:105
> + if( count > 4 )
ditto
> LayoutTests/inspector/storage-panel-dom-storage-update.html:126
> + InspectorTest.runAfterPendingDispatches( function() {
ditto
More information about the webkit-reviews
mailing list