[webkit-reviews] review granted: [Bug 86466] Web Inspector: AdvancedSearchController is not stopped then view is hidden. : [Attachment 141918] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted  review:
Bug 86466: Web Inspector: AdvancedSearchController is not stopped then view is
hidden.
https://bugs.webkit.org/show_bug.cgi?id=86466

Attachment 141918: Patch
https://bugs.webkit.org/attachment.cgi?id=141918&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review


>>> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360
>>> +	  * @override
>> 
>> We don't use @overrride annotation because it does not catch any error (try
renaming back to wasHidden and observe no compiler errors).
> 
> I've tried it before writing this annotation.
> Compiler doesn't catch this error, that's no good. But we can hope it will do
some day.
> 
> BUT this annotation not only for compiler, but also for developers, because
it make code a way core clear.

I don't think we should add compiler annotations for developers. We don't even
add comments usually.
Please remove this for consistency.