[webkit-reviews] review granted: [Bug 85353] [chromium] Add WebKit API to access inner text value of input element : [Attachment 141930] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 15 05:30:26 PDT 2012
Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 85353: [chromium] Add WebKit API to access inner text value of input
element
https://bugs.webkit.org/show_bug.cgi?id=85353
Attachment 141930: Patch
https://bugs.webkit.org/attachment.cgi?id=141930&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141930&action=review
> Source/WebKit/chromium/public/WebInputElement.h:81
> + // Sets the value inside the text field without being sanitized.
> + // Can't be used if a renderer doesn't exist or on a non text field
type.
> + WEBKIT_EXPORT void setEditingValue(const WebString&);
You should mention the caret position.
More information about the webkit-reviews
mailing list