[webkit-reviews] review granted: [Bug 86466] Web Inspector: AdvancedSearchController is not stopped then view is hidden. : [Attachment 141918] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 86466: Web Inspector: AdvancedSearchController is not stopped then view is
hidden.
https://bugs.webkit.org/show_bug.cgi?id=86466

Attachment 141918: Patch
https://bugs.webkit.org/attachment.cgi?id=141918&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review


> Source/WebCore/ChangeLog:6
> +	   AdvancedSearchController overrides "wasHidden" method instead of
"willHide".

Please move this line below "Reviewed by".

> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360
> +	* @override

We don't use @overrride annotation because it does not catch any error (try
renaming back to wasHidden and observe no compiler errors).