[webkit-reviews] review granted: [Bug 83012] Web Inspector: localStorage items are not updated when the storage changes : [Attachment 141753] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 83012: Web Inspector: localStorage items are not updated when the storage
changes
https://bugs.webkit.org/show_bug.cgi?id=83012

Attachment 141753: Patch
https://bugs.webkit.org/attachment.cgi?id=141753&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141753&action=review


Looks good. Please fix the comments before landing.

> Source/WebCore/inspector/InspectorDOMStorageResource.h:46
> +    class InspectorDOMStorageResource : public
RefCounted<InspectorDOMStorageResource> {

nit: I don't think it needs to be ref counted any longer.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:920
> +    InspectorAgent* inspectorAgent = instrumentingAgents->inspectorAgent();

Lines 920-922 are not necessary.

> LayoutTests/inspector/storage-panel-dom-storage-update.html:64
> +	       for( var i = 0; i < storages.length; i++ ) {

Here and below: no need for spaces before var and after i++. Also there should
be a space after for.
Also, we also do ++i in most cases.