[webkit-reviews] review requested: [Bug 82034] [Forms] Move numeric related methods in HTMLInputElement class to another place : [Attachment 141906] Patch 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 03:28:50 PDT 2012


yosin at chromium.org has asked  for review:
Bug 82034: [Forms] Move numeric related methods in HTMLInputElement class to
another place
https://bugs.webkit.org/show_bug.cgi?id=82034

Attachment 141906: Patch 4
https://bugs.webkit.org/attachment.cgi?id=141906&action=review

------- Additional Comments from yosin at chromium.org
Please review again.
Thanks in advance.

I did:
* Build with ENABLE_INPUT_TYPE_*
* Build with Chromium-Mac
* Changes as review comments
** Use StepRange ctor instead of setup method.
** Fix const String& issue for fastGetAttribute
* HTMLInputElement::createStepRange is used by sliderPosition in
SliderThumbElement.cpp
* Default ctor of StepRange is used by default method of
InputType::createStepRange


More information about the webkit-reviews mailing list