[webkit-reviews] review granted: [Bug 85353] [chromium] Add WebKit API to access inner text value of input element : [Attachment 141889] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 85353: [chromium] Add WebKit API to access inner text value of input
element
https://bugs.webkit.org/show_bug.cgi?id=85353

Attachment 141889: Patch
https://bugs.webkit.org/attachment.cgi?id=141889&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141889&action=review


ok

> LayoutTests/fast/forms/editing-value.html:20
> +  testPassed("onchange event was fired.");
> +};
> +input.oninput = function() {
> +  testPassed("oninput event was fired.");

nit: We prefer 4-space indentation.

> LayoutTests/fast/forms/editing-value.html:28
> +if (window.internals)
> +    internals.setEditingValue(input, " foo ");
> +shouldBe('input.value', '"foo"');
> +shouldBe('document.querySelector(":invalid")', 'input');
> +input.blur();

We had better show a message if window.internals is not available.