[webkit-reviews] review denied: [Bug 85353] [chromium] Add WebKit API to access inner text value of input element : [Attachment 141874] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 01:01:46 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 85353: [chromium] Add WebKit API to access inner text value of input
element
https://bugs.webkit.org/show_bug.cgi?id=85353

Attachment 141874: Patch
https://bugs.webkit.org/attachment.cgi?id=141874&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141874&action=review


r- because of build errors.

> Source/WebKit/chromium/public/WebInputElement.h:80
> +	   // Sets the value inside the text field without being sanitized.
> +	   WEBKIT_EXPORT void setEditingValue(const WebString&);

We had better mention the limitations of non-textfield types and renderer.


More information about the webkit-reviews mailing list