[webkit-reviews] review denied: [Bug 85353] [chromium] Add WebKit API to access inner text value of input element : [Attachment 141409] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 85353: [chromium] Add WebKit API to access inner text value of input
element
https://bugs.webkit.org/show_bug.cgi?id=85353

Attachment 141409: Patch
https://bugs.webkit.org/attachment.cgi?id=141409&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141409&action=review


r- because of build errors.

> Source/WebCore/html/HTMLInputElement.cpp:920
> +void HTMLInputElement::setEditingValue(const String& value)
> +{
> +    setInnerTextValue(value);
> +    subtreeHasChanged();
> +    dispatchInputEvent();
> +}

What happens if setEditingValue() is called for non-textfield input types, or
textfield without a renderer?