[webkit-reviews] review granted: [Bug 83576] [Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout : [Attachment 141811] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Michael Brüning
<michael.bruning at nokia.com>'s request for review:
Bug 83576: [Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with
timeout
https://bugs.webkit.org/show_bug.cgi?id=83576

Attachment 141811: Patch
https://bugs.webkit.org/attachment.cgi?id=141811&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141811&action=review


r=me. Only one small nitpick to fix when landing :)

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:565
> +	   && (hostname == QString::fromAscii("127.0.0.1") || hostname ==
QString::fromAscii("localhost")))

The string comparision should avoid allocating a new QString and instead use
QStringLiteral, i.e. if (hostName == QStringLiteral("127.0.0.1"))