[webkit-reviews] review granted: [Bug 83474] [Chromium] External popup menus should support early cancelation : [Attachment 136230] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 83474: [Chromium] External popup menus should support early cancelation
https://bugs.webkit.org/show_bug.cgi?id=83474

Attachment 136230: Patch
https://bugs.webkit.org/attachment.cgi?id=136230&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136230&action=review


> Source/WebKit/chromium/src/ExternalPopupMenu.cpp:76
> +    else
> +	   // The client might refuse to create a popup (when there is already
one pending to be shown for example).
> +	   didCancel();

nit: This else clause contains two physical lines.  So we need to enclose it
with {}.