[webkit-reviews] review denied: [Bug 86409] Site-specific hack: Disclaim WebM as a supported type on Mac for YouTube. : [Attachment 141807] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 86409: Site-specific hack: Disclaim WebM as a supported type on Mac for
YouTube.
https://bugs.webkit.org/show_bug.cgi?id=86409

Attachment 141807: Patch
https://bugs.webkit.org/attachment.cgi?id=141807&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141807&action=review


>>> Source/WebCore/html/HTMLMediaElement.cpp:625
>>> +	     if (document()->securityOrigin()->host().endsWith("youtube.com",
false)
>> 
>> Is it an issue with the way youtube encodes webm files or are other sites
affected?
>> 
>> I noticed the Perian folks just posted saying they're retiring the project
:\
> 
> Won’t this also match documents from the host www.thisisnotyoutube.com?

r- for reasons that Mitz gave. Right thing to do would be to test for either a
specific whitelist of hosts, or else exact match for "youtube.com" or suffix
match for ".youtube.com"..