[webkit-reviews] review denied: [Bug 86236] [chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux : [Attachment 141805] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Varun Jain <varunjain at chromium.org>'s
request for review:
Bug 86236: [chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on
chromium linux
https://bugs.webkit.org/show_bug.cgi?id=86236

Attachment 141805: Patch
https://bugs.webkit.org/attachment.cgi?id=141805&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141805&action=review


r- for Daniel's comment and the broken mac/win build.

> Source/WebCore/page/DragController.cpp:80
>      PlatformKeyboardEvent::getCurrentModifierState(shiftKey, ctrlKey,
altKey, metaKey);

You could maybe remove this call and implement the !CHROMIUM
getModifierKeyState in DragData.cpp.  It would just call this function and
construct the right keyState.

> Source/WebCore/platform/gtk/DragDataGtk.cpp:51
> +int DragData::getModifierKeyState() const
> +{
> +    return 0;

You could just put this in DragData.cpp behind an #if !PLATFORM(CHROMIUM). 
E.g., You forgot DragDataMac.mm.