[webkit-reviews] review granted: [Bug 86395] The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version : [Attachment 141777] Patch

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 86395: The "plug-in was blocked" callback needs to include enough info to
uniquely identify the plug-in + version
https://bugs.webkit.org/show_bug.cgi?id=86395

Attachment 141777: Patch
https://bugs.webkit.org/attachment.cgi?id=141777&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141777&action=review


> Source/WebKit2/UIProcess/WebLoaderClient.cpp:275
> +    m_client.pluginDidFail(toAPI(page), kWKErrorCodeCannotLoadPlugIn,
toAPI(mimeType.impl()), 0, 0, m_client.clientInfo);

It would be good to explain in the ChangeLog why we don't pass the new
parameters here.