[webkit-reviews] review denied: [Bug 83576] [Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout : [Attachment 141754] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Michael Brüning
<michael.bruning at nokia.com>'s request for review:
Bug 83576: [Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with
timeout
https://bugs.webkit.org/show_bug.cgi?id=83576

Attachment 141754: Patch
https://bugs.webkit.org/attachment.cgi?id=141754&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Good catch! I think your patch is correct in principle, the WK1 DRTs do
something similar. There's one difference between WK1 and your patch that I
think should be corrected: In WK1 (Mac and Qt) only SSL certificates for
127.0.0.1 and localhost are "blindly" accepted.

Also I think the private C++ API can go directly into QQuickWebView, see the
"Private C++-only API" comment. This isn't an experimental after all, we know
it's private only. I suppose a comment next to the function could indicate that
it's used by WTR, and perhaps it should be called
setAllowAnyHTTPSCertificateForLocalHost() or so.