[webkit-reviews] review denied: [Bug 86183] '; ' character is not handled correctly in Content-Disposition headers. : [Attachment 141650] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 14 10:57:54 PDT 2012
Adam Barth <abarth at webkit.org> has denied Jason
<jason.liu at torchmobile.com.cn>'s request for review:
Bug 86183: ';' character is not handled correctly in Content-Disposition
headers.
https://bugs.webkit.org/show_bug.cgi?id=86183
Attachment 141650: Patch
https://bugs.webkit.org/attachment.cgi?id=141650&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm sorry I'm not being more helpful, but your algorithm isn't correct. You
might find this implementation to be a useful guide:
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_content_dispositi
on.cc?view=markup
Even that implementation isn't 100% correct, but it's much closer than what's
in this patch.
More information about the webkit-reviews
mailing list