[webkit-reviews] review granted: [Bug 86371] Web Inspector: do not update $0-$4 console variables for the objects from loaded from file heap snapshot. : [Attachment 141739] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 86371: Web Inspector: do not update $0-$4 console variables for the objects
from loaded from file heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=86371

Attachment 141739: Patch
https://bugs.webkit.org/attachment.cgi?id=141739&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141739&action=review


> Source/WebCore/inspector/front-end/ProfilesPanel.js:278
> +	   temporaryProfile._fromFile = true;

Why not have WebInspector.ProfileHeader.prototype.loadFromFile do this?