[webkit-reviews] review granted: [Bug 85870] [EFL] Enable Fullscreen API : [Attachment 141369] Patch.

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 85870: [EFL] Enable Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=85870

Attachment 141369: Patch.
https://bugs.webkit.org/attachment.cgi?id=141369&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141369&action=review


looks good, not setting cq so you guys go with what you think it is better.

>> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:602
>>  bool ChromeClientEfl::supportsFullScreenForElement(const WebCore::Element*
element, bool withKeyboard)
> 
> Nit: the second parameter does not need to be named anymore.

i would name, and UNUSED_PARAM(withkeyboard);