[webkit-reviews] review granted: [Bug 86361] Web Inspector: [Extensions API] allow extensions to evaluate in the context of their content scripts : [Attachment 141700] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 86361: Web Inspector: [Extensions API] allow extensions to evaluate in the
context of their content scripts
https://bugs.webkit.org/show_bug.cgi?id=86361

Attachment 141700: Patch
https://bugs.webkit.org/attachment.cgi?id=141700&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141700&action=review


> Source/WebCore/inspector/front-end/ExtensionAPI.js:419
> +	   var callback = extractCallbackArgument(arguments);

Can we avoid this and have callback at a fixed position? Probably do it by
passing an arguments map as the firs parameter instead of expression string as
you suggested?

> Source/WebCore/inspector/front-end/ExtensionServer.js:729
> +	* @param {Object} options

Please keep parameter annotations in the same order as the parameters.

> Source/WebCore/inspector/front-end/JavaScriptContextManager.js:208
> +	   function comparator(securityOrigin, context)

I'd rather use a linear search here.

> Source/WebCore/inspector/front-end/JavaScriptContextManager.js:216
> +	       return this._isolatedContexts[index];

Pleas add explicit return statement for the case when there is no context
matching that security origin.