[webkit-reviews] review granted: [Bug 85942] Assertion failure running Mozilla's WebGL performance regression tests : [Attachment 141540] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 85942: Assertion failure running Mozilla's WebGL performance regression
tests
https://bugs.webkit.org/show_bug.cgi?id=85942

Attachment 141540: Patch
https://bugs.webkit.org/attachment.cgi?id=141540&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141540&action=review


OK.  r=me

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:715
> +	   const float scaleFactor = 1.0f / 255.0f;

Nit:  this could be hoisted out of the loop.

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:728
> +	   const float scaleFactor = 1.0f / 255.0f;

Same here.

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1099
> +	   float scaleFactor = 1.0f / (source[3] ? source[3] : 1.0f);

Might be clearer as
  float scaleFactor = source[3] ? 1.0f / source[3] : 1.0f;

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1137
> +	   float scaleFactor = 1.0f / (source[3] ? source[3] : 1.0f);

Same here.

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1178
> +	   float scaleFactor = 1.0f / (source[3] ? source[3] : 1.0f);

Same here.

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1209
> +	   float scaleFactor = 1.0f / (source[3] ? source[3] : 1.0f);

Same here.