[webkit-reviews] review canceled: [Bug 23750] Cannot resize frames because frameborder=0 : [Attachment 141332] Patch to allow resize of frames even in case of frameborder=0. - IV

Mon May 14 06:22:01 PDT 2012

Swapna <spottabathini at innominds.com> has canceled Swapna
<spottabathini at innominds.com>'s request for review:
Bug 23750: Cannot resize frames because frameborder=0
https://bugs.webkit.org/show_bug.cgi?id=23750

Attachment 141332: Patch to allow resize of frames even in case of
frameborder=0. - IV
https://bugs.webkit.org/attachment.cgi?id=141332&action=review

------- Additional Comments from Swapna <spottabathini at innominds.com>
> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:1
> +<html>
Normally you would want an HTML5 doctype here.	<!DOCTYPE html>

Added <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Frameset//EN"> as doctype.
Since <frame>&<frameset> tags are not supported in HTML5, we can't use HTML5
doctype.

>Don't you ahve a log function to do this?  I guess your log funciton isn't
general purpose.
Generalized log function.

> +  <frame frameborder=0 name="One" style="border-right: 2px solid green;" />
self-closing tags are invalid html.
Fixed.