[webkit-reviews] review granted: [Bug 86349] Web Inspector: Esc should revert the colorpicker-modifed color to the original : [Attachment 141679] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 86349: Web Inspector: Esc should revert the colorpicker-modifed color to
the original
https://bugs.webkit.org/show_bug.cgi?id=86349

Attachment 141679: Patch
https://bugs.webkit.org/attachment.cgi?id=141679&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141679&action=review


> Source/WebCore/inspector/front-end/Spectrum.js:422
> +	   this.dispatchEventToListeners(WebInspector.Spectrum.Events.Hidden,
!!cancelEdit);

Maybe invert this value?

> Source/WebCore/inspector/front-end/Spectrum.js:433
> +	       this.hide(event.keyIdentifier === "U+001B");

Maybe use two ifs?