[webkit-reviews] review granted: [Bug 67877] "border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border : [Attachment 141673] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 67877: "border: collapse" + "display: none" rows in the tbody while having
thead or tfoot doesn't render the opposite border
https://bugs.webkit.org/show_bug.cgi?id=67877

Attachment 141673: Patch
https://bugs.webkit.org/attachment.cgi?id=141673&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=141673&action=review


> LayoutTests/ChangeLog:23
> +	   * platform/efl/Skipped:
> +	   * platform/gtk/test_expectations.txt:
> +	   * platform/mac-wk2/Skipped:
> +	   * platform/mac/Skipped:
> +	   * platform/wincairo/Skipped:
> +	   Skipped fast/table/empty-section-crash.html since the expected
result
> +	   changes with the given fix.
> +
> +	   * platform/qt/fast/table/empty-section-crash-expected.png:
> +	   * platform/qt/fast/table/empty-section-crash-expected.txt:
> +	   Added the new expected results for
fast/table/empty-section-crash.html for
> +	   Qt platform.

I think you should switch this test to use layoutTestController.dumpAsText()
instead of skipping it all over the place. Your new test covers the rendering
change.