[webkit-reviews] review granted: [Bug 86306] DFG should be able to optimize foo.apply(bar, arguments) : [Attachment 141619] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 86306: DFG should be able to optimize foo.apply(bar, arguments)
https://bugs.webkit.org/show_bug.cgi?id=86306

Attachment 141619: the patch
https://bugs.webkit.org/attachment.cgi?id=141619&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141619&action=review


> Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp:72
> +			   

You probably didn't mean to do this.

> Source/JavaScriptCore/dfg/DFGCapabilities.cpp:45
> +    UNUSED_PARAM(result);

This is redundant (*shrug* :-) ).

> Source/JavaScriptCore/dfg/DFGDriver.cpp:53
> +    

Probably want to revert this file.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:948
> +    

Again probably want to revert.