[webkit-reviews] review granted: [Bug 86314] LayerFlushScheduler should be suspended when painting is suspended (background tabs, etc.) : [Attachment 141615] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 86314: LayerFlushScheduler should be suspended when painting is suspended
(background tabs, etc.)
https://bugs.webkit.org/show_bug.cgi?id=86314

Attachment 141615: patch
https://bugs.webkit.org/attachment.cgi?id=141615&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141615&action=review


> Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp:45
> +    if (!m_suspendCount)
>	   return;

Might want to assert or log here, since this means we did not balance our
suspend and resume calls properly.

>> Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp:49
>> +	if(!m_suspendCount)
> 
> Missing space before ( in if(  [whitespace/parens] [5]

I agree with stylebot. Could even consider an unconditional call to schedule,
since schedule already checks the suspend count.

> Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h:52
> +    unsigned int m_suspendCount;

Should just use the word unsigned here rather than unsigned int.