[webkit-reviews] review requested: [Bug 86306] DFG should be able to optimize foo.apply(bar, arguments) : [Attachment 141610] the patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 86306: DFG should be able to optimize foo.apply(bar, arguments)
https://bugs.webkit.org/show_bug.cgi?id=86306

Attachment 141610: the patch
https://bugs.webkit.org/attachment.cgi?id=141610&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Made some refinements to the way that CFG simplification treats captured
variables.  Previously I thought that it would be fine for CFG simplification
to not do any fix-up to captured vars after merging basic blocks.  But now I
think that it's cleaner if we preserve the invariant that even for captured
vars, a GetLocal refers to the first prior access to the same variable, thereby
ensuring that (1) we have a clean way of seeing the liveness of variables and
(2) the unification-based variable splitting "just works".  Of course, the
latter is only needed prior to CFG simplification, but I like the idea of CFG
simplification producing a graph that is strictly more tidy than the one it
received.