[webkit-reviews] review granted: [Bug 86303] [Texmap] TextureMapperAnimations does not support keyframe with multiple animations : [Attachment 141595] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 12 21:20:17 PDT 2012
Noam Rosenthal <noam.rosenthal at nokia.com> has granted Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 86303: [Texmap] TextureMapperAnimations does not support keyframe with
multiple animations
https://bugs.webkit.org/show_bug.cgi?id=86303
Attachment 141595: Patch
https://bugs.webkit.org/attachment.cgi?id=141595&action=review
------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141595&action=review
LGTM, except for some renames
> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:185
> + const Vector<TextureMapperAnimation>& animation = it->second;
animation -> animations
> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:198
> + const Vector<TextureMapperAnimation>& animation = it->second;
ditto
More information about the webkit-reviews
mailing list