[webkit-reviews] review denied: [Bug 86303] [Texmap] TextureMapperAnimations does not support keyframe with multiple animations : [Attachment 141584] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 12 18:09:44 PDT 2012
Noam Rosenthal <noam.rosenthal at nokia.com> has denied Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 86303: [Texmap] TextureMapperAnimations does not support keyframe with
multiple animations
https://bugs.webkit.org/show_bug.cgi?id=86303
Attachment 141584: Patch
https://bugs.webkit.org/attachment.cgi?id=141584&action=review
------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141584&action=review
> Source/WebCore/ChangeLog:18
> + [Texmap] TextureMapperAnimations does not support keyframe with
multiple animations
> + https://bugs.webkit.org/show_bug.cgi?id=86303
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + * platform/graphics/texmap/TextureMapperAnimation.cpp:
> + (WebCore::TextureMapperAnimations::hasActiveAnimationsOfType):
> + (WebCore::TextureMapperAnimations::hasRunningAnimations):
> + (WebCore::TextureMapperAnimations::add):
> + (WebCore):
> + (WebCore::TextureMapperAnimations::pause):
> + (WebCore::TextureMapperAnimations::apply):
> + * platform/graphics/texmap/TextureMapperAnimation.h:
> + (TextureMapperAnimations): Use HashMap<String,
Vector<TextureMapperAnimation> >,
> + so we can support an keyframe with multiple animations.
> +
Insufficient changelog.
More information about the webkit-reviews
mailing list