[webkit-reviews] review granted: [Bug 86235] [BlackBerry] Allow the platform media player to determine the media element's paused/playing status : [Attachment 141575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 12 09:40:49 PDT 2012


George Staikos <staikos at kde.org> has granted Max Feil <mfeil at rim.com>'s request
for review:
Bug 86235: [BlackBerry] Allow the platform media player to determine the media
element's paused/playing status
https://bugs.webkit.org/show_bug.cgi?id=86235

Attachment 141575: Patch
https://bugs.webkit.org/attachment.cgi?id=141575&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141575&action=review


Seems fine though could have been slightly simpler.  I'll r+ anyway.  Not a
substantial concern.

>
Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:72
8
> +    if (!element || element->paused())

This could be reduced to:

return !element || element->paused();


More information about the webkit-reviews mailing list