[webkit-reviews] review denied: [Bug 86157] Should have Node::inDetach() for assertion purposes. : [Attachment 141307] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Hajime Morrita <morrita at google.com>'s
request for review:
Bug 86157: Should have Node::inDetach() for assertion purposes.
https://bugs.webkit.org/show_bug.cgi?id=86157

Attachment 141307: Patch
https://bugs.webkit.org/attachment.cgi?id=141307&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141307&action=review


> Source/WebCore/dom/Node.cpp:1343
> +static Node* detachingNode;
> +
> +bool Node::inDetach() const
> +{
> +    return detachingNode == this;
> +}

This global variable and the body of the inDetach function should be
NDEBUG-only. We don’t want to pay the price for setting a global used only for
assertions in a build without assertions.