[webkit-reviews] review granted: [Bug 86000] Take referrer policy into account when clearing the referrer header : [Attachment 141552] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 23:12:49 PDT 2012


Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 86000: Take referrer policy into account when clearing the referrer header
https://bugs.webkit.org/show_bug.cgi?id=86000

Attachment 141552: Patch
https://bugs.webkit.org/attachment.cgi?id=141552&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141552&action=review


Holy duplicated code batman.

> Source/WebCore/loader/ResourceLoader.cpp:237
> +    if (!m_frame->document() || m_frame->document()->referrerPolicy() ==
ReferrerPolicyDefault) {

!m_frame->document() <- shouldn't be possible.


More information about the webkit-reviews mailing list