[webkit-reviews] review granted: [Bug 86028] Don't append log lines while perf tests are running. : [Attachment 141039] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 86028: Don't append log lines while perf tests are running.
https://bugs.webkit.org/show_bug.cgi?id=86028

Attachment 141039: Patch
https://bugs.webkit.org/attachment.cgi?id=141039&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141039&action=review


We've started adding tests in
http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/perftests not
that I think we should add a test for this.

> PerformanceTests/resources/runner.js:171
> +    this._showLogLinesAtEndOfTest = !!window.layoutTestController;
> +    this._logLines = [];

We can just do:
this._logLines = window.layoutTestController ? [] : undefined;
That way, we don't need _showLogLinesAtEndOfTest.