[webkit-reviews] review granted: [Bug 86239] REGRESSION (r114170): Scroll areas in nested frames improperly placed when tiled drawing is enabled : [Attachment 141539] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jeffrey Pfau
<jeffrey at endrift.com>'s request for review:
Bug 86239: REGRESSION (r114170): Scroll areas in nested frames improperly
placed when tiled drawing is enabled
https://bugs.webkit.org/show_bug.cgi?id=86239

Attachment 141539: Patch
https://bugs.webkit.org/attachment.cgi?id=141539&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141539&action=review


> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:110
> +static Region computeNonFastScrollableRegion(Frame* frame, const IntPoint&
parentCorner = IntPoint())

Instead of "parentCorner" I'd call this frameLocation, since corner could be
any of the four frame corners :)

Also, don't use a default argument here. It's better to just pass IntPoint() at
the call site.