[webkit-reviews] review denied: [Bug 86270] [Chromium] android/WebInputEventFactory should handle wheel events and gesture events : [Attachment 141522] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 16:19:42 PDT 2012


Adam Barth <abarth at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 86270: [Chromium] android/WebInputEventFactory should handle wheel events
and gesture events
https://bugs.webkit.org/show_bug.cgi?id=86270

Attachment 141522: Patch
https://bugs.webkit.org/attachment.cgi?id=141522&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141522&action=review


>> Source/WebKit/chromium/public/android/WebInputEventFactory.h:59
>> +							    long
timeStampSeconds,
> 
> a timestamp in seconds of an integral type seems completely useless. is this
milliseconds (like DOMTimeStamp)? is the type here wrong or the name?

You're right.  I've goofed this up.  One moment.


More information about the webkit-reviews mailing list