[webkit-reviews] review denied: [Bug 86239] Scroll areas in nested frames improperly placed when tiled drawing is enabled : [Attachment 141519] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jeffrey Pfau
<jeffrey at endrift.com>'s request for review:
Bug 86239: Scroll areas in nested frames improperly placed when tiled drawing
is enabled
https://bugs.webkit.org/show_bug.cgi?id=86239

Attachment 141519: Patch
https://bugs.webkit.org/attachment.cgi?id=141519&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141519&action=review


> Source/WebCore/ChangeLog:10
> +	   Scroll areas in nested frames improperly placed when tiled drawing
is enabled
> +	   https://bugs.webkit.org/show_bug.cgi?id=86239
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Iteratively add positions of parent frames to placement of nested
frame scroll areas.
> +
> +	   Manual tests: ManualTests/scrollable-positioned-frame.html

This needs more explanation of what broke it and why this fix helps.

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:124
> +	       for (Frame* nestedFrame = frame; owner; nestedFrame =
owner->document()->frame(), owner = nestedFrame->ownerElement())
> +	       if (owner->renderPart())
> +		  
offset.moveBy(owner->renderPart()->widget()->frameRect().location());

Weird indentation here. You want { } around the two lines.