[webkit-reviews] review granted: [Bug 86255] [chromium] Plumb --show-paint-rects to accelerated compositor : [Attachment 141506] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 86255: [chromium] Plumb --show-paint-rects to accelerated compositor
https://bugs.webkit.org/show_bug.cgi?id=86255

Attachment 141506: Patch
https://bugs.webkit.org/attachment.cgi?id=141506&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141506&action=review


R=me - one question for you to consider before setting CQ.

> Source/WebKit/chromium/public/WebSettings.h:111
> +    virtual bool showPaintRects() const = 0;

do we need this getter? most other settings don't have one and i have an
allergy to unused getters (feels too much like writing a java bean or
something)

WebViewImpl can access its m_webSettings to talk to a WebSettingsImpl interface