[webkit-reviews] review denied: [Bug 86236] [chromium] Implement PlatformKeyboardEvent::getCurrentModifierState for non win/mac : [Attachment 141455] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 15:28:16 PDT 2012


Tony Chang <tony at chromium.org> has denied Varun Jain <varunjain at chromium.org>'s
request for review:
Bug 86236: [chromium] Implement PlatformKeyboardEvent::getCurrentModifierState
for non win/mac
https://bugs.webkit.org/show_bug.cgi?id=86236

Attachment 141455: Patch
https://bugs.webkit.org/attachment.cgi?id=141455&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
r- since this won't work in the sandbox.

This might work by making it a sync IPC back to the browser process and
handling it on the render thread.  There's some similar code in
src/content/browser/renderer_host/render_widget_host_impl.cc. The
OnMessageReceived function is where we handle the IPC on the browser side-- you
would add something in the TOOLKIT_GTK block.  But I still think this is going
to be really slow since talking to X can be slow.  E.g., typing into a textarea
over a remote X connection would be good to try.


More information about the webkit-reviews mailing list