[webkit-reviews] review granted: [Bug 86049] [chromium] create WebTransformationMatrix interface for chromium platform : [Attachment 141458] Addressed reviewer comments

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 86049: [chromium] create WebTransformationMatrix interface for chromium
platform
https://bugs.webkit.org/show_bug.cgi?id=86049

Attachment 141458: Addressed reviewer comments
https://bugs.webkit.org/attachment.cgi?id=141458&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141458&action=review


Looks great!

>>>> Source/Platform/chromium/public/WebTransformationMatrix.h:52
>>>> +	  WebTransformationMatrix(double a, double b, double c, double d,
double e, double f);
>>> 
>>> The parameter name "b" adds no information, so it should be removed. 
[readability/parameter_name] [5]
>> 
>> The parameter name "d" adds no information, so it should be removed. 
[readability/parameter_name] [5]
> 
> The parameter name "e" adds no information, so it should be removed. 
[readability/parameter_name] [5]

I think the style guide is wrong on this, FWIW

> Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp:30
> +#include <wtf/PassOwnPtr.h>

is this #include being used?