[webkit-reviews] review denied: [Bug 86215] [chromium] MediaStream API: Moving the Platform create* WebRTC calls into a factory : [Attachment 141428] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 86215: [chromium] MediaStream API: Moving the Platform create* WebRTC calls
into a factory
https://bugs.webkit.org/show_bug.cgi?id=86215

Attachment 141428: Patch
https://bugs.webkit.org/attachment.cgi?id=141428&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141428&action=review


> Source/Platform/chromium/public/Platform.h:300
> +    virtual WebWebRTCFactory* webRTCFactory() { return 0; }

WebWeb -> so many Webs!

I don't understand why we need this lever of indirection.  Can't DumpRenderTree
just override the virtual functions below without creating a separate factory
object in the API?